root/regexper-static
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fixing label rendering for repetition

Browse Source 
Rendering a text element with a string leads to just a <text/> element.
Rendering with an array leads to <text><tspan/></text>. Decided to use
the latter since it matches with the majority of text rendering
currently in use.
This commit is contained in:
Jeff Avallone 2015-09-03 17:08:20 -04:00
parent 4169720eb2
commit 6c9f5d4cb6
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
spec/parser/javascript/match_fragment_spec.js
View File

@ -163,7 +163,7 @@ describe('parser/javascript/match_fragment.js', function() {
it('renders a text element', function() { it('renders a text element', function() {
this.node.loopLabel(); this.node.loopLabel();
expect(this.node.container.text).toHaveBeenCalledWith(0, 0, 'example label'); expect(this.node.container.text).toHaveBeenCalledWith(0, 0, ['example label']);
}); });
describe('when there is a skip loop', function() { describe('when there is a skip loop', function() {

2
src/js/parser/javascript/match_fragment.js
View File

@ -56,7 +56,7 @@ export default {
label, labelBox, box; label, labelBox, box;
if (labelStr) { if (labelStr) {
label = this.container.text(0, 0, labelStr) label = this.container.text(0, 0, [labelStr])
.addClass('repeat-label'); .addClass('repeat-label');
box = this.getBBox(); box = this.getBBox();