From 6c9f5d4cb6c5683edeea4f193e7457834c195c71 Mon Sep 17 00:00:00 2001 From: Jeff Avallone Date: Thu, 3 Sep 2015 17:08:20 -0400 Subject: [PATCH] Fixing label rendering for repetition Rendering a text element with a string leads to just a element. Rendering with an array leads to . Decided to use the latter since it matches with the majority of text rendering currently in use. --- spec/parser/javascript/match_fragment_spec.js | 2 +- src/js/parser/javascript/match_fragment.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/spec/parser/javascript/match_fragment_spec.js b/spec/parser/javascript/match_fragment_spec.js index 7b280e2..baa3f74 100644 --- a/spec/parser/javascript/match_fragment_spec.js +++ b/spec/parser/javascript/match_fragment_spec.js @@ -163,7 +163,7 @@ describe('parser/javascript/match_fragment.js', function() { it('renders a text element', function() { this.node.loopLabel(); - expect(this.node.container.text).toHaveBeenCalledWith(0, 0, 'example label'); + expect(this.node.container.text).toHaveBeenCalledWith(0, 0, ['example label']); }); describe('when there is a skip loop', function() { diff --git a/src/js/parser/javascript/match_fragment.js b/src/js/parser/javascript/match_fragment.js index cd23ecb..c2e786c 100644 --- a/src/js/parser/javascript/match_fragment.js +++ b/src/js/parser/javascript/match_fragment.js @@ -56,7 +56,7 @@ export default { label, labelBox, box; if (labelStr) { - label = this.container.text(0, 0, labelStr) + label = this.container.text(0, 0, [labelStr]) .addClass('repeat-label'); box = this.getBBox();