Commit Graph

51 Commits

Author SHA1 Message Date
Jeff Avallone
fd27e28918 Merge pull request #24 from Byron/repeat-edge-cases
'{0}' label is not shown anymore
2016-03-03 07:19:01 -05:00
Sebastian Thiel
b08a9d95f7 '{0}' label is not shown anymore
Previously, '{0}' would be labelled as '-1 Times', which is not actually the case.
Also I am not sure to best visualize such a pattern, right now, except for the label,
'a{0}' looks similar to 'a?', even though they don't have the same effect.
2016-01-03 18:27:34 +01:00
Sebastian Thiel
7a591bb4a8 cleanup special 'definedProperties' field in Node
'definedProperties' seems like module-meta-data, which shouldn't be on a Node instance.
2016-01-03 15:59:50 +01:00
Jeff Avallone
966ab5f2d6 Fixing lint errors 2015-11-01 10:28:37 -05:00
Jeff Avallone
c90d09a1e0 Updating karma-browserify
This required updating import paths in the spec files
2015-10-31 12:09:38 -04:00
Jeff Avallone
6c9f5d4cb6 Fixing label rendering for repetition
Rendering a text element with a string leads to just a <text/> element.
Rendering with an array leads to <text><tspan/></text>. Decided to use
the latter since it matches with the majority of text rendering
currently in use.
2015-09-03 17:08:20 -04:00
Jeff Avallone
06a7ffc110 Moving skip and loop line calculation into Repeat nodes
This code seems more at home in Repeat instead of MatchFragment since
Repeat knows about the dimensions of the lines for the contentPosition
value.
2015-04-23 20:03:25 -04:00
Jeff Avallone
1ef8bd7500 Adding documentation and a few tweaks to node.js 2015-04-19 16:40:53 -04:00
Jeff Avallone
8796c1329c Reorganizing and cleanup of base Node code 2015-04-19 12:06:22 -04:00
Jeff Avallone
5917d2b035 Updating getBBox and anchor code to improve performance
This change will reduce the number of calls to this.container.getBBox
when calculating the bounding box of a node
2015-04-16 17:13:12 -04:00
Jeff Avallone
0093db8e20 Replacing Q promises with ES6 promises 2015-03-14 17:11:14 -04:00
Jeff Avallone
3970224302 Removing use of notify to update progress bar 2015-03-14 14:01:25 -04:00
Jeff Avallone
7328825204 Changing when subexpression numbers are generated
Generating subexp numbers during setup was leading to nested expressions
being numbered in reverse order.

Fixes #7
2015-03-13 20:23:04 -04:00
Jeff Avallone
49ac454922 Removing tests for undefined proxy
The proxy is still undefined, but these tests now fail with the latest
node
2015-03-07 17:12:25 -05:00
Jeff Avallone
1170a1be76 Displaying the hex code of escaped characters
This is only done where appropriate (escapes like "word boundary" don't
have a hex value, and displaying it for hex or unicode escapes would be
a little redundant).
2015-01-25 17:44:07 -05:00
Jeff Avallone
cb359bf4dd Adding support for rendering empty subexpressions
Fixes #1
2014-12-30 17:06:29 -05:00
Jeff Avallone
e890fe7d2c Updating progress using the promise notify feature 2014-12-29 17:35:18 -05:00
Jeff Avallone
08fdb254fc Adding failure paths for all async tests
This will ensure the tests fail if the intended path isn't followed
2014-12-27 16:04:22 -05:00
Jeff Avallone
aa6c792867 Adding tests for Match nodes 2014-12-26 12:48:02 -05:00
Jeff Avallone
cf159c28a5 Finishing tests for MatchFragment nodes 2014-12-26 10:57:46 -05:00
Jeff Avallone
6793b342ae Using fancy quotes for literals 2014-12-23 23:07:51 -05:00
Jeff Avallone
d909312b94 Starting tests for MatchFragment nodes 2014-12-23 22:23:03 -05:00
Jeff Avallone
f264eee5f9 Adding tests for Regexp nodes 2014-12-23 11:02:15 -05:00
Jeff Avallone
8a9178c11e Adding pending test file for remaining nodes 2014-12-22 20:36:14 -05:00
Jeff Avallone
e3eedb17af Adding tests for Root nodes 2014-12-22 20:35:49 -05:00
Jeff Avallone
f842b424cc Adding warnings for non-standard escape sequence usage 2014-12-22 16:57:30 -05:00
Jeff Avallone
281ca50d32 Adding some more checks for CharsetRange tests 2014-12-22 16:16:17 -05:00
Jeff Avallone
b35dece228 Fixing character set ranges
Certain escape sequences are not considered in ranges, and lead to the
hyphen to be part of the matched set of characters
2014-12-22 16:09:27 -05:00
Jeff Avallone
d882ee8e08 Adding check that charset range is in correct order 2014-12-22 15:18:49 -05:00
Jeff Avallone
9b8eef9c02 Setting ordinals for literals 2014-12-22 15:11:37 -05:00
Jeff Avallone
d4b648fa43 Setting ordinal for control code escapes 2014-12-22 15:11:20 -05:00
Jeff Avallone
101b457260 Adding ordinal values to escapes
Work still needs to be done to get control characters correct, and
ordinals will need to be added for literals as well. This is in
preparation for reporting incorrectly ordered charset ranges
2014-12-22 12:44:19 -05:00
Jeff Avallone
961d4812e9 Adding tests for Charset nodes 2014-12-22 10:57:16 -05:00
Jeff Avallone
9bf5328da7 Adding specs for Subexp nodes 2014-12-21 12:05:55 -05:00
Jeff Avallone
9e6702d475 Fixing top-level spec descriptions 2014-12-21 11:24:23 -05:00
Jeff Avallone
94c674e879 Finishing Repeat node specs 2014-12-21 10:27:40 -05:00
Jeff Avallone
82ca4f40f7 Adding initial tests for Repeat nodes 2014-12-20 13:03:57 -05:00
Jeff Avallone
55657a792b Adding check for out of order numbers 2014-12-20 10:53:01 -05:00
Jeff Avallone
8a9a129856 Adding tests for CharsetRange nodes 2014-12-20 10:18:00 -05:00
Jeff Avallone
d27831a265 Adding tests for CharsetEscape nodes 2014-12-19 21:56:56 -05:00
Jeff Avallone
24e21834f6 Adding tests for Escape nodes 2014-12-19 21:49:11 -05:00
Jeff Avallone
32a28ede90 Adding tests for Literal nodes 2014-12-19 21:35:03 -05:00
Jeff Avallone
94ff093824 Adding specs for AnyCharacter node 2014-12-19 21:05:44 -05:00
Jeff Avallone
8c8fbf648d Adding tests for RepeatSpec nodes 2014-12-19 21:00:38 -05:00
Jeff Avallone
8669d0c4bc Adding specs for the basic repetitions 2014-12-19 20:55:01 -05:00
Jeff Avallone
a50ba68a21 Moving spaceHorizontally and spaceVertically to util.js 2014-12-19 12:11:44 -05:00
Jeff Avallone
870b2e6ed4 Moving normalizeBBox to util.js 2014-12-19 12:06:21 -05:00
Jeff Avallone
abb5838113 Updating how async specs are called 2014-12-19 11:51:34 -05:00
Jeff Avallone
be145e3fac Adding rest of tests for Node class 2014-12-19 11:48:09 -05:00
Jeff Avallone
91581afe2c Adding more Node tests 2014-12-19 11:00:47 -05:00