Merging some shared styles

This commit is contained in:
Jeff Avallone 2014-12-30 10:17:55 -05:00
parent c809913fe7
commit fc6ffbd73a
3 changed files with 25 additions and 20 deletions

View File

@ -30,6 +30,12 @@ describe('parser/javascript.js', function() {
expect(element.innerHTML).not.toEqual('example content'); expect(element.innerHTML).not.toEqual('example content');
}); });
it('adds the "svg-container" class', function() {
spyOn(this.parser, '_addClass');
this.parser.container = document.createElement('div');
expect(this.parser._addClass).toHaveBeenCalledWith('svg-container');
});
}); });
describe('#parse', function() { describe('#parse', function() {

View File

@ -28,6 +28,7 @@ export default class Parser {
document.querySelector('#svg-container-base').innerHTML, document.querySelector('#svg-container-base').innerHTML,
this.options.keepContent ? this.container.innerHTML : '' this.options.keepContent ? this.container.innerHTML : ''
].join(''); ].join('');
this._addClass('svg-container');
} }
get container() { get container() {
@ -35,11 +36,17 @@ export default class Parser {
} }
_addClass(className) { _addClass(className) {
this.container.className = _.compact([this.container.className, className]).join(' '); this.container.className = _(this.container.className.split(' '))
.union([className])
.value()
.join(' ');
} }
_removeClass(className) { _removeClass(className) {
this.container.className = _.without(this.container.className.split(' '), className).join(' '); this.container.className = _(this.container.className.split(' '))
.without(className)
.value()
.join(' ');
} }
parse(expression) { parse(expression) {

View File

@ -48,6 +48,15 @@ ul.inline-list {
} }
} }
.svg-container {
min-width: 200px;
&.loading .svg {
position: absolute;
top: -10000px;
}
}
#deprecation-notice { #deprecation-notice {
@include background(linear-gradient(top, $green, $dark-green)); @include background(linear-gradient(top, $green, $dark-green));
background-color: $green; background-color: $green;
@ -209,15 +218,6 @@ header {
margin-right: rhythm(1/2); margin-right: rhythm(1/2);
} }
&.loading {
min-width: 100px;
.svg {
position: absolute;
top: -10000px;
}
}
.svg { .svg {
margin: 0; margin: 0;
text-align: center; text-align: center;
@ -354,15 +354,7 @@ header {
text-align: center; text-align: center;
display: none; display: none;
body.is-loading & { body.is-loading &,
display: block;
.svg {
position: absolute;
top: -10000px;
}
}
body.has-results & { body.has-results & {
display: block; display: block;
} }