Adding warnings for non-standard escape sequence usage

This commit is contained in:
Jeff Avallone
2014-12-22 16:57:30 -05:00
parent a4f831bc60
commit f842b424cc
9 changed files with 71 additions and 2 deletions
+9
View File
@@ -1,4 +1,5 @@
import javascript from 'src/js/parser/javascript/parser.js';
import Node from 'src/js/parser/javascript/node.js';
import util from 'src/js/util.js';
import _ from 'lodash';
import Snap from 'snapsvg';
@@ -49,6 +50,14 @@ describe('parser/javascript/charset.js', function() {
});
});
it('adds a warning for character sets the contain non-standard escapes', function() {
var node;
Node.state = { warnings: [] };
node = new javascript.Parser('[\\c]').__consume__charset();
expect(node.state.warnings).toEqual(['The character set "[\\c]" contains the \\c escape followed by a character other than A-Z. This can lead to different behavior depending on browser. The representation here is the most common interpretation.']);
});
describe('_anchor property', function() {
it('calculates the anchor based on the partContainer', function() {
+9
View File
@@ -119,4 +119,13 @@ describe('parser/javascript.js', function() {
});
describe('warnings property', function() {
it('returns the content of the warnings state variable', function() {
this.parser.state.warnings.push('example');
expect(this.parser.warnings).toEqual(['example']);
});
});
});
+15
View File
@@ -11,6 +11,7 @@ describe('regexper.js', function() {
this.root.innerHTML = [
'<form id="regexp-form" action="/"><input type="text" id="regexp-input" /></form>',
'<div id="error"></div>',
'<ul id="warnings"></ul>',
'<div><a href="#" data-glyph="link-intact"></a></div>',
'<div><a href="#" data-glyph="data-transfer-download"></a></div>',
'<div id="progress"><div></div></div>',
@@ -355,6 +356,15 @@ describe('regexper.js', function() {
});
describe('#displayWarnings', function() {
it('adds a list item for each warning', function() {
this.regexper.displayWarnings(['warning 1', 'warning 2']);
expect(this.regexper.warnings.innerHTML).toEqual('<li class="oi with-text" data-glyph="warning">warning 1</li><li class="oi with-text" data-glyph="warning">warning 2</li>');
});
});
describe('#renderRegexp', function() {
beforeEach(function() {
@@ -366,6 +376,7 @@ describe('regexper.js', function() {
spyOn(this.regexper, '_trackEvent');
spyOn(this.regexper, 'updateLinks');
spyOn(this.regexper, 'displayWarnings');
this.regexper.renderRegexp('example expression');
});
@@ -440,6 +451,10 @@ describe('regexper.js', function() {
expect(this.regexper.updateLinks).toHaveBeenCalled();
});
it('displays the warnings', function() {
expect(this.regexper.displayWarnings).toHaveBeenCalled();
});
it('tracks the complete render', function() {
expect(this.regexper._trackEvent).toHaveBeenCalledWith('visualization', 'complete');
});