root/regexper-static
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

cleanup special 'definedProperties' field in Node

Browse Source 
'definedProperties' seems like module-meta-data, which shouldn't be on a Node instance.
This commit is contained in:
Sebastian Thiel 2016-01-03 15:59:50 +01:00 committed by Jeff Avallone
parent 95b283faa8
commit a624c00554
2 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
spec/parser/javascript/node_spec.js
View File

@ -26,7 +26,7 @@ describe('parser/javascript/node.js', function() {
expect(setup).toHaveBeenCalled(); expect(setup).toHaveBeenCalled();
}); });
it('sets up any defined properties', function() { it('sets up any defined properties and removes \'definedProperties\' field', function() {
this.node.module = { this.node.module = {
definedProperties: { definedProperties: {
example: { example: {
@ -37,6 +37,7 @@ describe('parser/javascript/node.js', function() {
} }
}; };
expect(this.node.example).toEqual('value'); expect(this.node.example).toEqual('value');
expect(this.node.definedProperties).toBeUndefined();
}); });
}); });

2
src/js/parser/javascript/node.js
View File

@ -30,6 +30,8 @@ export default class Node {
_.forOwn(this.definedProperties || {}, (methods, name) => { _.forOwn(this.definedProperties || {}, (methods, name) => {
Object.defineProperty(this, name, methods); Object.defineProperty(this, name, methods);
}); });
delete this.definedProperties;
} }
// The SVG element to render this node into. A node-type class is // The SVG element to render this node into. A node-type class is