Revert "Adding a HOC for using StaticQuery"

This reverts commit 3b11fcb0b6.

src/components/Footer/__snapshots__/test.js.snap

@@ -4,7 +4,13 @@ exports[`Footer rendering 1`] = `
 ShallowWrapper {
   Symbol(enzyme.__root__): [Circular],
   Symbol(enzyme.__unrendered__): <Footer
-    buildId="abc-123"
+    site={
+      Object {
+        "siteMetadata": Object {
+          "buildId": "abc-123",
+        },
+      }
+    }
     t={[Function]}
   />,
   Symbol(enzyme.__renderer__): Object {

src/components/Footer/index.js

@@ -1,10 +1,8 @@
 import React from 'react';
 import PropTypes from 'prop-types';
-import { graphql } from 'gatsby';
+import { StaticQuery, graphql } from 'gatsby';
 import { withNamespaces, Trans } from 'react-i18next';
 
-import withQuery from 'lib/with-query';
-
 import style from './style.module.css';
 
 const query = graphql`
@@ -17,7 +15,7 @@ const query = graphql`
   }
 `;
 
-export const Footer = ({ t, buildId }) => (
+export const Footer = ({ t, site: { siteMetadata } }) => (
   <footer className={ style.footer }>
     <ul className={ style.list }>
       <li>
@@ -35,19 +33,22 @@ export const Footer = ({ t, buildId }) => (
       </li>
     </ul>
     <div className={ style.buildId }>
-      { buildId }
+      { siteMetadata.buildId }
     </div>
   </footer>
 );
 
 Footer.propTypes = {
   t: PropTypes.func.isRequired,
+  site: PropTypes.shape({
+    siteMetadata: PropTypes.shape({
       buildId: PropTypes.string.isRequired
+    }).isRequired
+  }).isRequired
 };
 
-export default [
+export default withNamespaces()(props => (
-  withQuery(query, {
+  <StaticQuery query={ query } render={ data => (
-    toProps: ({ site: { siteMetadata } }) => siteMetadata
+    <Footer { ...props } { ...data } />
-  }),
+  ) } />
-  withNamespaces()
+));
-].reduce((component, fn) => fn(component), Footer);

src/components/Footer/test.js

@@ -7,7 +7,7 @@ import { Footer } from 'components/Footer';
 describe('Footer', () => {
   test('rendering', () => {
     const component = shallow(
-      <Footer buildId="abc-123" t={ mockT } />
+      <Footer site={{ siteMetadata: { buildId: 'abc-123' } }} t={ mockT } />
     );
     expect(component).toMatchSnapshot();
   });

src/components/Header/__snapshots__/test.js.snap

@@ -4,7 +4,13 @@ exports[`Header rendering 1`] = `
 ShallowWrapper {
   Symbol(enzyme.__root__): [Circular],
   Symbol(enzyme.__unrendered__): <Header
-    banner="testing"
+    site={
+      Object {
+        "siteMetadata": Object {
+          "banner": "testing",
+        },
+      }
+    }
   />,
   Symbol(enzyme.__renderer__): Object {
     "batchedUpdates": [Function],
@@ -534,7 +540,13 @@ exports[`Header rendering with no banner 1`] = `
 ShallowWrapper {
   Symbol(enzyme.__root__): [Circular],
   Symbol(enzyme.__unrendered__): <Header
-    banner={false}
+    site={
+      Object {
+        "siteMetadata": Object {
+          "banner": false,
+        },
+      }
+    }
   />,
   Symbol(enzyme.__renderer__): Object {
     "batchedUpdates": [Function],

src/components/Header/index.js

@@ -1,11 +1,10 @@
 import React from 'react';
 import PropTypes from 'prop-types';
-import { Link, graphql } from 'gatsby';
+import { Link, StaticQuery, graphql } from 'gatsby';
 import { withNamespaces, Trans } from 'react-i18next';
 
 import GitlabIcon from 'react-feather/dist/icons/gitlab';
 
-import withQuery from 'lib/with-query';
 import LocaleSwitcher from 'components/LocaleSwitcher';
 
 import style from './style.module.css';
@@ -20,10 +19,10 @@ const query = graphql`
   }
 `;
 
-export const Header = ({ banner }) => (
+export const Header = ({ site: { siteMetadata } }) => (
   <header
     className={ style.header }
-    data-banner={ banner || null }>
+    data-banner={ siteMetadata.banner || null }>
     <h1>
       <Link to="/">Regexper</Link>
     </h1>
@@ -50,15 +49,18 @@ export const Header = ({ banner }) => (
 );
 
 Header.propTypes = {
+  site: PropTypes.shape({
+    siteMetadata: PropTypes.shape({
       banner: PropTypes.oneOfType([
         PropTypes.bool,
         PropTypes.string
       ]).isRequired
+    }).isRequired
+  }).isRequired
 };
 
-export default [
+export default withNamespaces()(props => (
-  withQuery(query, {
+  <StaticQuery query={ query } render={ data => (
-    toProps: ({ site: { siteMetadata } }) => siteMetadata
+    <Header { ...props } { ...data } />
-  }),
+  ) } />
-  withNamespaces()
+));
-].reduce((component, fn) => fn(component), Header);

src/components/Header/test.js

@@ -6,14 +6,14 @@ import { Header } from 'components/Header';
 describe('Header', () => {
   test('rendering', () => {
     const component = shallow(
-      <Header banner="testing" />
+      <Header site={{ siteMetadata: { banner: 'testing' } }} />
     );
     expect(component).toMatchSnapshot();
   });
 
   test('rendering with no banner', () => {
     const component = shallow(
-      <Header banner={ false } />
+      <Header site={{ siteMetadata: { banner: false } }} />
     );
     expect(component).toMatchSnapshot();
   });

src/components/Layout/__snapshots__/test.js.snap

@@ -20,11 +20,11 @@ ShallowWrapper {
     "nodeType": "class",
     "props": Object {
       "children": Array [
-        <LoadNamespace(WithQuery(Header)) />,
+        <LoadNamespace(Component) />,
         <SentryBoundary>
           Example content
         </SentryBoundary>,
-        <LoadNamespace(WithQuery(Footer)) />,
+        <LoadNamespace(Component) />,
       ],
     },
     "ref": null,
@@ -68,11 +68,11 @@ ShallowWrapper {
       "nodeType": "class",
       "props": Object {
         "children": Array [
-          <LoadNamespace(WithQuery(Header)) />,
+          <LoadNamespace(Component) />,
           <SentryBoundary>
             Example content
           </SentryBoundary>,
-          <LoadNamespace(WithQuery(Footer)) />,
+          <LoadNamespace(Component) />,
         ],
       },
       "ref": null,

src/lib/with-query.js

@@ -1,21 +0,0 @@
-import React from 'react';
-import { StaticQuery } from 'gatsby';
-
-const withQuery = (query, options = {}) => Component => {
-  const { toProps } = {
-    toProps: data => data,
-    ...options
-  };
-  const displayName = Component.displayName || Component.name || 'Component';
-  const wrapped = props => (
-    <StaticQuery query={ query } render={ data => (
-      <Component { ...props } { ...toProps(data) } />
-    ) } />
-  );
-
-  wrapped.displayName = `WithQuery(${ displayName })`;
-
-  return wrapped;
-};
-
-export default withQuery;