root/regexper-static
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Refactoring tracking code

Browse Source 
This is to support the new Google Analytics setup
This commit is contained in:
Jeff Avallone
2016-05-23 21:10:50 -04:00
parent 9add3984d6
commit 6a0999f644
5 changed files with 35 additions and 37 deletions
Download Patch File Download Diff File Expand all files Collapse all files
spec/regexper_spec.js
+6 -7
View File
@@ -23,7 +23,6 @@ describe('regexper.js', function() {
this.regexper = new Regexper(this.root);
spyOn(this.regexper, '_setHash');
spyOn(this.regexper, '_getHash');
spyOn(window._gaq, 'push');
});
describe('#keypressListener', function() {
@@ -193,7 +192,7 @@ describe('regexper.js', function() {
it('tracks the event', function() {
this.regexper.hashchangeListener();
expect(window._gaq.push).toHaveBeenCalledWith(['_trackEvent', 'visualization', 'malformed URL']);
expect(util.track).toHaveBeenCalledWith('send', 'event', 'visualization', 'malformed URL');
});
});
@@ -391,7 +390,7 @@ describe('regexper.js', function() {
it('tracks the beginning of the render', function() {
this.regexper.renderRegexp('example expression');
expect(window._gaq.push).toHaveBeenCalledWith(['_trackEvent', 'visualization', 'start']);
expect(util.track).toHaveBeenCalledWith('send', 'event', 'visualization', 'start');
});
it('keeps a copy of the running property parser', function() {
@@ -429,7 +428,7 @@ describe('regexper.js', function() {
it('tracks the parse error', function(done) {
this.regexper.renderRegexp('example expression')
.then(() => {
expect(window._gaq.push).toHaveBeenCalledWith(['_trackEvent', 'visualization', 'parse error']);
expect(util.track).toHaveBeenCalledWith('send', 'event', 'visualization', 'parse error');
done();
});
});
@@ -489,7 +488,7 @@ describe('regexper.js', function() {
it('tracks the complete render', function(done) {
this.regexper.renderRegexp('example expression')
.then(() => {
expect(window._gaq.push).toHaveBeenCalledWith(['_trackEvent', 'visualization', 'complete']);
expect(util.track).toHaveBeenCalledWith('send', 'event', 'visualization', 'complete');
done();
});
});
@@ -505,7 +504,7 @@ describe('regexper.js', function() {
it('tracks the total rendering time', function(done) {
this.regexper.renderRegexp('example expression')
.then(() => {
expect(window._gaq.push).toHaveBeenCalledWith(['_trackTiming', 'visualization', 'total time', jasmine.any(Number)]);
expect(util.track).toHaveBeenCalledWith('send', 'timing', 'visualization', 'total time', jasmine.any(Number));
done();
});
});
@@ -531,7 +530,7 @@ describe('regexper.js', function() {
it('tracks the cancelled render', function(done) {
this.regexper.renderRegexp('example expression')
.then(() => {
expect(window._gaq.push).toHaveBeenCalledWith(['_trackEvent', 'visualization', 'cancelled']);
expect(util.track).toHaveBeenCalledWith('send', 'event', 'visualization', 'cancelled');
done();
});
});
spec/setup_spec.js
+6 -4
View File
@@ -1,3 +1,5 @@
import util from '../src/js/util.js';
// Setup (and teardown) SVG container template
beforeEach(function() {
var template = document.createElement('script');
@@ -25,7 +27,7 @@ afterEach(function() {
document.body.removeChild(document.body.querySelector('#svg-container-base'));
});
// Spy on _gaq.push to prevent unnecessary logging
window._gaq = {
push() {}
}
// Spy on util.track to prevent unnecessary logging
beforeEach(function() {
spyOn(util, 'track');
});